Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree branches not properly aligned, branch doesn't start at branching point #109

Open
fapdash opened this issue Jun 23, 2024 · 4 comments
Open

Comments

@fapdash
Copy link

fapdash commented Jun 23, 2024

Somehow the branches of my vundo tree don't align properly, this happens with utf8 glyphs, as well as with default ascii:

With unicode-symbols (keycast output in tab-bar)

Peek.2024-06-23.12-34.mp4

ascii with Symbola font family

Peek.2024-06-23.12-39.mp4

ascii with Ubuntu font family

Peek.2024-06-23.12-45.mp4

My config:

(use-package vundo
  :ensure t
  :config
  (setq vundo-glyph-alist vundo-unicode-symbols)
  (set-face-attribute 'vundo-default nil :family "Symbola")
  (global-set-key (kbd "C-x u") 'vundo))

Do you have any idea why this would be happening? Anything I could do to help with debugging this issue?

@casouri
Copy link
Owner

casouri commented Jun 24, 2024

You need to use a monospace font for both ascii and unicode. Ascii is easier since most programming font are monospace; for unicode, you need to find a monospace font that has those glyphs. I use pragmata pro but it's paid. You can find what font is Emacs using for a character in a buffer by moving point over it and type C-u C-x =.

@fapdash
Copy link
Author

fapdash commented Jun 24, 2024

Are there versions of Symbola that contain a monospaced version that I could find? I'm a bit confused since Symbola gets recommended in the README.

I then also ran into an issue where some of the glyphs where using Ubuntu Mono and some where using Fira Code.
What worked for me was this, with nerd-fonts installed via nerd-fonts.el:

(set-face-attribute 'vundo-default nil :font "FiraCode Nerd Font Mono" :family "FireCode Nerd Font")

@casouri
Copy link
Owner

casouri commented Jun 25, 2024

Actually, I don't quite remember why I mentioned Symbola in the README 😅 Thanks for pointing that out, I probably should remove its mention. Nerd font looks good, you figured it out quite well!

@fapdash
Copy link
Author

fapdash commented Jun 25, 2024

Thank you for your guidance and the great package! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants