Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multinut LND #492

Merged
merged 21 commits into from
May 22, 2024
Merged

Multinut LND #492

merged 21 commits into from
May 22, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Mar 23, 2024 •
edited
Loading

Todo:

  • NUT-05 mpp
  • Wallet check /info for mpp before attempting
  • Experimental setting to enable MPP

Implements cashubtc/nuts#103

@callebtc callebtc changed the title Multinut Multinut LND Mar 23, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 47.85276% with 85 lines in your changes are missing coverage. Please review.

Project coverage is 63.30%. Comparing base (3b2f1aa) to head (eacd157).
Report is 10 commits behind head on main.

Files Patch % Lines
cashu/lightning/lndrest.py 10.63% 42 Missing ⚠️
cashu/wallet/mint_info.py 55.17% 13 Missing ⚠️
cashu/mint/router.py 0.00% 7 Missing ⚠️
cashu/mint/router_deprecated.py 0.00% 5 Missing ⚠️
cashu/core/base.py 86.20% 4 Missing ⚠️
cashu/wallet/cli/cli.py 33.33% 4 Missing ⚠️
cashu/mint/ledger.py 0.00% 2 Missing ⚠️
cashu/wallet/api/router.py 0.00% 2 Missing ⚠️
cashu/wallet/wallet.py 86.66% 2 Missing ⚠️
cashu/lightning/corelightningrest.py 66.66% 1 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
- Coverage   69.62%   63.30%   -6.33%     
==========================================
  Files          76       77       +1     
  Lines        6913     7060     +147     
==========================================
- Hits         4813     4469     -344     
- Misses       2100     2591     +491

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc force-pushed the multinut branch 5 times, most recently from 5049f62 to c5832ef Compare May 22, 2024 10:59
@callebtc callebtc marked this pull request as ready for review May 22, 2024 20:50
@callebtc callebtc merged commit 61cf7de into main May 22, 2024
16 checks passed
@callebtc callebtc deleted the multinut branch May 22, 2024 20:52
@benthecarman benthecarman mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@callebtc