Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Melt quotes use case-insensitive request #479

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Conversation

callebtc
Copy link
Collaborator

Combination of Blink and eNuts revealed a but where internal payments would not be detected as such because eNuts requests payment of an upper-case LN invoice and the corresponding internal mint request string is a lower-case bolt11 invoice.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.58%. Comparing base (86b8f58) to head (d279958).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
+ Coverage   68.56%   68.58%   +0.02%     
==========================================
  Files          74       74              
  Lines        6683     6685       +2     
==========================================
+ Hits         4582     4585       +3     
+ Misses       2101     2100       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 30cdb81 into main Mar 16, 2024
15 checks passed
@callebtc callebtc deleted the blink-enuts-request-case branch March 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant