Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message details when adding mint fails #364

Open
jblachly opened this issue Aug 25, 2024 · 1 comment
Open

Improve error message details when adding mint fails #364

jblachly opened this issue Aug 25, 2024 · 1 comment
Labels
proposal Kick off new ideas and suggestions

Comments

@jblachly
Copy link

I am trying to add a test mint (Moksha, in this case) while home on my LAN (192.168.1.0/24). However, while I can connect to the mint from other computers on the LAN with CLI wallets (and with curl), I am not able to add this mint to eNuts. The error message "Network request failed" is sufficiently generic that I am not sure whether this is a socket connection failure, or a higher-level protocol failure.

Version: iOS 0.4 beta (enable access to LAN for eNuts beta is enabled in settings)
Mint url: http://192.168.1.x:yyyyy (note http, not https; and a nonstandard port)

I would love it if the error were more specific to help debug setup. "Couldn't connect" or "HTTPS expected", etc.

Thanks for considering

@KKA11010
Copy link
Collaborator

KKA11010 commented Sep 5, 2024

Hi @jblachly , thanks a lot for opening the issue.

From my experience, I can say with almost 99% certainty that iOS restricts requests that are not over HTTPS. This has also happened to me even in dev environments. sometimes it would randomly work, but more often it fails due to security policies I believe.

Unfortunately, it might be tricky to differentiate between specific error types such as 'couldn't connect' or 'HTTPS expected' because they are often masked as generic network failures. However, I’ll keep this in mind as a possible improvement for the future.

Thanks again for bringing this up!

@KKA11010 KKA11010 added the proposal Kick off new ideas and suggestions label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Kick off new ideas and suggestions
Projects
None yet
Development

No branches or pull requests

2 participants