Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support paying amountless bolt11 #460

Open
thesimplekid opened this issue Nov 18, 2024 · 6 comments · May be fixed by #497
Open

Support paying amountless bolt11 #460

thesimplekid opened this issue Nov 18, 2024 · 6 comments · May be fixed by #497
Assignees
Labels

Comments

@thesimplekid
Copy link
Collaborator

cashubtc/nuts#173

@mubarak23
Copy link
Contributor

@thesimplekid let me have take at this

@mubarak23
Copy link
Contributor

when a mint PostMeltQuoteBolt11Response has amount set to 0, this mean the wallet is trying to get an amountless (zero-amount invoice) request invoice in the request a melt quote,

when this happen, we are going to check mint MeltMethodSetting if it's support for amountless bolt11

@thesimplekid

@thesimplekid
Copy link
Collaborator Author

No, the PostMeltQuoteBolt11Request should be extend to have an optional field as in the linked nut pr of the amount in the case of an amount less invoice. If this is supported by the mint then that amount should be paid. There should also be a check that if there is also an amount in the invoice it is the same as requested. The PostMeltQuoteBolt11Response does not need to change.

@mubarak23
Copy link
Contributor

i understand, so if there is an option amount field set in PostMeltQuoteBolt11Request then mint should check if it's support amountless (zero-amount invoice), then ensure the amount field match what is in the request bolt11 Lightning invoice

@thesimplekid
Copy link
Collaborator Author

Yes.

then ensure the amount field match what is in the request bolt11 Lightning invoice

Only if there is amount included in the invoice.

@mubarak23
Copy link
Contributor

Yes.

then ensure the amount field match what is in the request bolt11 Lightning invoice

Only if there is amount included in the invoice.

can an invoice comes without an amount

@thesimplekid thesimplekid linked a pull request Dec 9, 2024 that will close this issue
2 tasks
@thesimplekid thesimplekid self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants