-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flakey CI tests when minting #432
Comments
I would like to work on this. |
Go for it, thanks. We should just be able to add a loop in that checks for the quote to be marked as paid by polling the check endpoint. I think one of the tests does this not there is an example here, though in the tests with fake wallet we should be able to sleep for less time. |
The errors are occuring in Some more information would be helpful. |
Those are logged errors but in the test they are expected since it is checking error cases they aren't causing tests to fail. The flaky tests on the mint, there are currently just sleeps in place between getting the mint quote and attempting to fill it where the fake wallet should mark it as paid. But occasionally this sleep isnt long enough so it should be replaces will the loop checking the state as i linked above.
|
Some of the ci tests fail when the wallet attempts to mint before the invoice is marked as paid. We should wait till mint invoice is paid by polling check endpoint
The text was updated successfully, but these errors were encountered: