Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUT-17: Websockets #203

Closed
thesimplekid opened this issue Jun 27, 2024 · 9 comments
Closed

NUT-17: Websockets #203

thesimplekid opened this issue Jun 27, 2024 · 9 comments
Assignees
Labels

Comments

@thesimplekid
Copy link
Collaborator

cashubtc/nuts#98 (comment)

@crodas
Copy link
Contributor

crodas commented Aug 10, 2024

@thesimplekid can I work on this? I'm rewriting this in my nostr relayer, and I successfully did it in my tiny ledger database (which has a long polling HTTP interface), so I'm quite familiar with how to solve it.

Let me know if you already started so I can find another thing to work on.

Cheers,

@thesimplekid
Copy link
Collaborator Author

Hey @crodas,

Sure go for it thank you

@thesimplekid
Copy link
Collaborator Author

thesimplekid commented Aug 31, 2024

@crodas Have you started on this? How is it coming?

@crodas
Copy link
Contributor

crodas commented Aug 31, 2024

@thesimplekid I'm a few days away (perhaps a week) from having a working prototype. Is the timeline ok?

@thesimplekid
Copy link
Collaborator Author

Yes thats fine. Feel free to publish a draft pr if you want me to take a look at anything even before its working.

@thesimplekid
Copy link
Collaborator Author

@crodas I'm going to take this back.

@crodas crodas mentioned this issue Oct 8, 2024
4 tasks
@crodas
Copy link
Contributor

crodas commented Oct 9, 2024

@thesimplekid did you have time to take a look at my WIP PR? I'm extending it and add more tests to both the nut17 implementation, the subscription mod and I'll add it the WebSocket handler.

@prusnak
Copy link
Contributor

prusnak commented Nov 6, 2024

PR #394 has been merged

Should this issue be closed or is there still something left to be done?

@thesimplekid
Copy link
Collaborator Author

Should this issue be closed or is there still something left to be done?

#394 Is mint only so we do still need wallets support, @crodas said he would work on that so lets close this and ill open another tracking issue for that.

Thanks tracking this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants