Weird behaviour in knowThisMintOfTokenJson

[prusnak]

Function knowThisMintOfTokenJson is weird.

cashu.me/src/components/ReceiveTokenDialog.vue

Lines 193 to 204 in c43001b

	knowThisMintOfTokenJson: function (tokenJson) {
	const mintStore = useMintsStore();
	// check if we have all mints
	for (var i = 0; i < tokenJson.token.length; i++) {
	if (
	!mintStore.mints.map((m) => m.url).includes(token.getMint(tokenJson))
	) {
	return false;
	}
	}
	return true;
	},

It iterates over i, but then the i variable is not used anywhere.

It seems like this is not intended.

[ok300]

You may want to separate by token type.

For V4, the token contains a single mint URL and all included proofs are for that mint:

V4 tokens are a space-efficient way of serializing tokens using the CBOR binary format. All field are single characters and hex strings are encoded in binary. V4 tokens can only hold proofs from a single mint.
https://github.com/cashubtc/nuts/blob/main/00.md

Then you don't need to iterate over the tokens in the JSON, as the mint URL is included in the root: https://github.com/cashubtc/nuts/blob/main/00.md#token-format-1

For V3, yes a token can have proofs from multiple mints: https://github.com/cashubtc/nuts/blob/main/00.md#example

You could also just deprecate V3 and keep it simple.

[prusnak]

Has been fixed in f39eb7f

We can close this issue.