Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use keysets with hex ids when creating proofs to send #192

Open
elnosh opened this issue Jul 4, 2024 · 2 comments
Open

use keysets with hex ids when creating proofs to send #192

elnosh opened this issue Jul 4, 2024 · 2 comments

Comments

@elnosh
Copy link
Contributor

elnosh commented Jul 4, 2024

some mints still have non-hex keyset ids. Example minibits mint has keysets:

"keysets": [
  {
    "id": "9mlfd5vCzgGl",
    "unit": "sat",
    "active": true
  },
  {
    "id": "00500550f0494146",
    "unit": "sat",
    "active": true
  }

when creating proofs to send, it generated proofs like such:

"proofs": [
  {
    "amount": 1,
    "secret": "60822b310d5a197d370dcf9948a1cff2b8fd95846d3c55fde2992e3da96d3290",
    "C": "03bea6d0cc5a1d83cced22b3ac00585101d756d0ffaef59642a3904efb046f7cd1",
    "reserved": true,
    "id": "9mlfd5vCzgGl"
  },
 ...
],
"mint": "https://mint.minibits.cash/Bitcoin"

using keyset id 9mlfd5vCzgGl instead of using the hex keyset id 00500550f0494146

@prusnak
Copy link
Contributor

prusnak commented Oct 14, 2024

Is this still an open issue? I seem not to have any issues when using that particular mint.

@elnosh
Copy link
Contributor Author

elnosh commented Oct 31, 2024

just tried it and yeah it's using the hex keyset id now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants