Extract out common Yoga FlexContainer logic
#1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
reviewed
Jul 28, 2023
| import app.cash.redwood.ui.Margin | ||
| import app.cash.redwood.yoga.Node | ||
|
|
||
| interface YogaFlexContainer<W : Any> : FlexContainer<W> { |
There was a problem hiding this comment.
This is a pretty small module to carry and to put into public API. Could we accomplish this with a new copyPasta.kt entry? Or maybe it could be added to the existing FlexboxHelpers?
There was a problem hiding this comment.
I think I was imagining third party implementations that could depend on this module. I've definitely back-tracked on that thinking since this PR, so I've just chucked it in FlexboxHelpers as you suggested.
veyndan
force-pushed
the
veyndan/2023-07-28/yoga-flex-container
branch
from
f4c66eb to
55c1d31
Compare
JakeWharton
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.