Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in emoji-search after scroll position preservation commit #1604

Closed
JakeWharton opened this issue Oct 17, 2023 · 2 comments · Fixed by #1606
Closed

Crash in emoji-search after scroll position preservation commit #1604

JakeWharton opened this issue Oct 17, 2023 · 2 comments · Fixed by #1606
Labels
sample/emoji

Comments

@JakeWharton
Copy link
Collaborator

I haven't properly reviewed the PR yet, but I'm noticing a crash in Emoji Search after these changes:

  • Run Emoji Search using Android Views
  • Type "medal" into the search box
  • Click on one of the medal emojis
  • Press the system back button
  • The app crashes with the exception app.cash.zipline.ZiplineException: IllegalArgumentException: Failed requirement.

Originally posted by @veyndan in #1599 (comment)
@jingwei99
Copy link

looking!

@jingwei99
Copy link

So this crash happens when the list on screen (filtered search result) is shorter than the whole screen.

@jingwei99 jingwei99 mentioned this issue Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sample/emoji
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash on scroll position restoration cashapp/redwood
2 participants
@JakeWharton @jingwei99