Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This should be a Box. #1524

Open
github-actions bot opened this issue Sep 28, 2023 · 3 comments
Open

This should be a Box. #1524

github-actions bot opened this issue Sep 28, 2023 · 3 comments

Comments

@github-actions
Copy link

https://api.github.com/cashapp/redwood/blob/8a90744632cc3e5183e02bc6a0f2cc600b981ad7/test-app/presenter/src/commonMain/kotlin/com/example/redwood/testing/presenter/TestApp.kt#L45


  } else {
    val onBack = { screen.value = null }
    BackHandler(onBack = onBack)
    Column(width = Fill, height = Fill) {
      Button("Back", onClick = onBack)

      // TODO This should be a Box.
      Column(
        width = Fill,
        horizontalAlignment = Stretch,
        modifier = Modifier.grow(1.0).horizontalAlignment(Stretch),
      ) {
        activeScreen.Show(httpClient)
      }
    }
  }
}

@JakeWharton
Copy link
Collaborator

Blocked by #900

@JakeWharton
Copy link
Collaborator

Blocked only by DOM Box. Even if iOS Box has bugs we can still switch.

@JakeWharton
Copy link
Collaborator

iOS Box is all good now. Blocked by DOM box only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant