Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots (as image) missing in test-report for 1.3.5 #1703

Open
TheRishka opened this issue Nov 19, 2024 · 2 comments
Open

Screenshots (as image) missing in test-report for 1.3.5 #1703

TheRishka opened this issue Nov 19, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@TheRishka
Copy link

Description
I have noticed in release-notes for 1.3.5 there was a nice feature added: Screenshot in test-report.
However, I couldn't find any documentation on how to enable that, so I assumed it works out-of-the-box.
So I did a sample project to see how it works and it doesn't work there. No errors also seen in logs.
Could be a bug, or what am I doing wrong? :)

Steps to Reproduce

Expected behavior
I expected to see delta images in the output failure report.

Additional information:

  • Paparazzi Version: 1.3.5
  • Compile SDK: 35
  • Gradle Version: 8.9
  • Android Gradle Plugin Version: 8.7

Screenshots
Image

@TheRishka TheRishka added the bug Something isn't working label Nov 19, 2024
@TheRishka
Copy link
Author

Noticed in this PR (#1675) a screenshot of how it works. Doesn't work for me though... is there a special setup that needs to be done, or some "enable"-flag to turn on?
Image

@geoff-powell
Copy link
Collaborator

geoff-powell commented Nov 21, 2024

So running verify task in your sample repo showed an error where the original file did not exist
Image

Then running record, changing the test text from `"Hello Brother" to "Hello Sister Sister" did not show the delta image in the test report.

It looks like the main issue is your package name seems to break our delimiter _ in the filename of generated snapshots.
I was able to change package name references from "com.example.test_paparazzi" to "com.example.testpaparazzi" and rerun the suggested steps and it provided the correct output.

Image

Our filename parsing for diffs is pretty brittle. I think going forward we plan on generating a manifest file in our verification output to better solve this problem.

##1708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants