-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could custom parameters be mutable? #44
Comments
I meant it to be immutable so you can check history. For example if you wanted to know "did we run backfill for this set of customers?" you can find the backfill with those parameters. If there was a very good audit log maybe mutable parameters would be fine. If we do, caching of the backfill instance also needs to be changed. Right now caching is by backfila database id and the backfill could save some computations based on parameters that would need to be invalidated. |
Maybe we can flag parameters as either mutable or immutable? I agree an audit log of when and the state of the backfill when it was changed would make it a better proposition. |
I think the right way to handle this is make a copy the old backfill to a new create backfill request. |
…de-and-merge to master * commit '5744612282ac1ab067684d266f42181d31ebdcb5': Automatic commit from polyrepo dep-upgrade-and-commit. Changes:
Requiring custom parameters to be immutable means creating a lot of extra backfills in some cases. Would be great if they were mutable like the batch size, scan size, etc.
The text was updated successfully, but these errors were encountered: