Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use native python APIs + minor changes #184

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: use native python APIs + minor changes #184

wants to merge 2 commits into from

Conversation

ClashLuke
Copy link

Also included:

  • PyCharm reformat
  • fStrings vs string concatenation (Python >=3.7 required)
  • Add handling for lastExistingFrame is None
  • Print help when no argument provided
  • Minor bugfixes for edge cases

@ClashLuke
feat: use native python APIs + minor changes
44281e2 
Also included:
* PyCharm reformat
* fStrings vs string concatenation (Python >=3.7 required)
* Add handling for lastExistingFrame is None
* Print help when no argument provided
* Minor bugfixes for edge cases
@ClashLuke
fix: use pytube3
eaba3eb 
PyTube is incompatible with this repo. PyTube3 is _required_ for python>=3.8 and usable for any python3.
@leemunhei123
Copy link

Nice! Hope this gets in the jumpcutter github!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClashLuke @leemunhei123