-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support tilde in semver constraints #172
Comments
hmm, this is a toughie. any thoughts on relationship of |
Since the original use case is to avoid the prereleases of the version found in 1.3, I would say they should be included ideally. |
Sorry was reading this issue and I think I did not follow 100%. Are you suggesting that the output of
But if you did
|
Yes, you got it. |
Looks like an interesting addition. For implementation sake, we will have to change the library https://github.com/k14s/semver in order to have support for the |
Describe the problem/challenge you have
I want to support 1.2.x for a given version, including pre-releases, but given something like this:
It's hard to figure out where to put the <, since
1.3.0-build.x
is considered less than 1.3.0Changing it to something like:
Causes you to miss the high numbers of
1.2.x
.Describe the solution you'd like
~
exists in several upstream semver libraries, so you can do something like:And it'll work for all patch versions of 1.2, but exclude anything in 1.3 or higher.
Anything else you would like to add:
While this is extremely unlikely in the exemplified upstream product (TAP), I wanted to capture this in case the scenario becomes increasingly likely. Pretty sure my use case is satisified by just picking something like 1000 for the patch release (I'm actually just using 1.2.9 now since that also seems likely to work)
Vote on this request
This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.
👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"
We are also happy to receive and review Pull Requests if you want to help working on this issue.
The text was updated successfully, but these errors were encountered: