Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to support --allow-change-package-name (or similar) in the kctrl pacakge installed update command #1651

Open
luwangVMW opened this issue Nov 27, 2024 · 1 comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request

Comments

@luwangVMW
Copy link

Describe the problem/challenge you have
[A description of the current challenge that you are experiencing.]
we have installed a package CR. When there is new version package available, however its metadata name is changed, kctrl pacakge installed update command block us from updating the packageinstall with new package.
https://www.google.com.hk/url?sa=j&url=https%3A%2F%2Fgithub.com%2Fcarvel-dev%2Fkapp-controller%2Fblob%2Fe4b4822224f7bd06e27787a013e3c3e997beb043%2Fcli%2Fpkg%2Fkctrl%2Fcmd%2Fpackage%2Finstalled%2Fcreate_or_update.go%23L774&uct=1666834461&usg=QuqlyDCjJqv1qaQ2BMA8Qe66XS4.&opi=73833047&source=chat

We could directly edit packageinstall CR to update package reference and everything goes well.

Describe the solution you'd like
[A clear and concise description of what you want to happen. If applicable a visual representation of the UX.]
Ask to support --allow-change-package-name in the kctrl pacakge installed update command, to not check the package name.

Anything else you would like to add:
[Additional information that will assist in solving the issue.]


Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

@luwangVMW luwangVMW added carvel-triage This issue has not yet been reviewed for validity enhancement This issue is a feature request labels Nov 27, 2024
@renuy renuy added carvel-accepted This issue should be considered for future work and that the triage process has been completed and removed carvel-triage This issue has not yet been reviewed for validity labels Nov 29, 2024
@renuy renuy moved this to Prioritized Backlog in Carvel Nov 29, 2024
@100mik
Copy link
Contributor

100mik commented Nov 29, 2024

Hey @luwangVMW ! We had a discussion about this, and we are okay with dropping this check altogether.
Would you like to raise a PR making the change? We will prioritise a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
carvel-accepted This issue should be considered for future work and that the triage process has been completed enhancement This issue is a feature request
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

3 participants