kctrl : Successful message when package install failed

[rcmadhankumar]

What steps did you take:
I tried installing a package for which the version didn't exist:

kctrl package install -i foo -p foo.myorg.com -v 1.0.0 -n test-ns 
Target cluster 'https://127.0.0.1:56506' (nodes: kind-control-plane)

10:24:28AM: Creating service account 'foo-test-ns-sa'
10:24:28AM: Creating cluster admin role 'foo-test-ns-cluster-role'
10:24:28AM: Creating cluster role binding 'foo-test-ns-cluster-rolebinding'
10:24:28AM: Creating overlay secrets
10:24:28AM: Creating package install resource
10:24:28AM: Waiting for PackageInstall reconciliation for 'foo'

kctrl: Error: packageinstall/foo (packaging.carvel.dev/v1alpha1) namespace: test-ns:
  Reconciling: . Reconcile failed:
    Package foo.myorg.com not found

^This works as expected, but when I try running the same command again, I got a different error:

kctrl package install -i foo -p foo.myorg.com -v 1.0.0 -n test-ns 
Target cluster 'https://127.0.0.1:56506' (nodes: kind-control-plane)

10:24:31AM: No changes to package install 'foo' in namespace 'test-ns'

Succeeded

What happened:
kctrl returns Succeeded as there is no new changes in the package install.

What did you expect:
kctrl should make sure that the last reconciliation was successful, only then it can return success message, otherwise it should be reconcile failure error.

---

Vote on this request

This is an invitation to the community to vote on issues, to help us prioritize our backlog. Use the "smiley face" up to the right of this comment to vote.

👍 "I would like to see this addressed as soon as possible"
👎 "There are other more important things to focus on right now"

We are also happy to receive and review Pull Requests if you want to help working on this issue.

[github-actions]

This issue is being marked as stale due to a long period of inactivity and will be closed in 5 days if there is no response.