Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the test case TestConfig_TrustCACerts ( ssl on is removed) #1345

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fixing the test case TestConfig_TrustCACerts ( ssl on is removed) #1345

merged 1 commit into from
Oct 12, 2023

Conversation

rohitagg2020
Copy link
Contributor

What this PR does / why we need it:

Removed ssl on from nginx.conf as this configuration is not supported anymore by nginx.
Replaced it with listen 443 ssl

Which issue(s) this PR fixes:

Fixing the test case TestConfig_TrustCACerts
Fixes #

Does this PR introduce a user-facing change?

None

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:

praveenrewar
praveenrewar approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@praveenrewar praveenrewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@praveenrewar
Copy link
Member

Can we also cherry pick this to the other lts branches?

@rohitagg2020
Copy link
Contributor Author

Can we also cherry pick this to the other lts branches?

Will do it once it is merged

@rohitagg2020 rohitagg2020 merged commit 43f2334 into develop Oct 12, 2023
11 checks passed
@praveenrewar praveenrewar deleted the ra-fix-test-config-trust-ca-certs branch October 12, 2023 19:27
@rohitagg2020
Copy link
Contributor Author

/cherry-pick 0.46.x

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Oct 16, 2023
@kumaritanushree
Copy link
Contributor

/cherry-pick 0.46.x

@kumaritanushree kumaritanushree removed the carvel-triage This issue has not yet been reviewed for validity label Oct 16, 2023
@sethiyash
Copy link
Contributor

/cherry-pick 0.46.x

@github-actions github-actions bot added the carvel-triage This issue has not yet been reviewed for validity label Oct 16, 2023
@sethiyash
Copy link
Contributor

/cherry-pick 0.45.x

@sethiyash
Copy link
Contributor

/cherry-pick 0.44.x

@vmunishwar
Copy link
Contributor

/cherry-pick 0.46.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praveenrewar praveenrewar praveenrewar approved these changes

@neil-hickey neil-hickey Awaiting requested review from neil-hickey

Assignees
No one assigned
Labels
carvel-triage This issue has not yet been reviewed for validity
Projects
Carvel
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohitagg2020 @praveenrewar @kumaritanushree @sethiyash @vmunishwar