-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add defaultNamespace in pkgi/app crs #1317
Conversation
74567a5
to
2979a03
Compare
2979a03
to
e90917c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of smaller things about formatting / libs used. The overall code and whatnot looks good
not sure if yall already settled on the name, if so ignore, but if not, id like to throw in
|
e90917c
to
432d470
Compare
Signed-off-by: Praveen Rewar <[email protected]>
432d470
to
d96d1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
Add defaultNamespace field in App and PackageInstall spec. This can be used to set the default namespace where the resources will be created. Currently this is the same as the App namespace.
Which issue(s) this PR fixes:
Fixes #1318
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: