Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultNamespace in pkgi/app crs #1317

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

praveenrewar
Copy link
Member

@praveenrewar praveenrewar commented Sep 4, 2023

What this PR does / why we need it:

Add defaultNamespace field in App and PackageInstall spec. This can be used to set the default namespace where the resources will be created. Currently this is the same as the App namespace.

Which issue(s) this PR fixes:

Fixes #1318

Does this PR introduce a user-facing change?

Introduce defaultNamespace in Apps and PackageInstalls. This can be used to set the default namespace where the resources will be installed.

Additional Notes for your reviewer:

Review Checklist:
  • Follows the developer guidelines
  • Relevant tests are added or updated
  • Relevant docs in this repo added or updated
  • Relevant carvel.dev docs added or updated in a separate PR and there's
    a link to that PR
  • Code is at least as readable and maintainable as it was before this
    change

Additional documentation e.g., Proposal, usage docs, etc.:


@praveenrewar praveenrewar marked this pull request as draft September 4, 2023 05:57
@praveenrewar praveenrewar force-pushed the installation-namespace branch 3 times, most recently from 74567a5 to 2979a03 Compare September 4, 2023 12:55
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of smaller things about formatting / libs used. The overall code and whatnot looks good

config/config/crds.yml Outdated Show resolved Hide resolved
hack/dependencies.yml Outdated Show resolved Hide resolved
pkg/app/app_deploy.go Show resolved Hide resolved
pkg/packageinstall/packageinstall.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/installation_namespace_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/installation_namespace_test.go Outdated Show resolved Hide resolved
test/e2e/kappcontroller/installation_namespace_test.go Outdated Show resolved Hide resolved
@cppforlife
Copy link
Contributor

not sure if yall already settled on the name, if so ignore, but if not, id like to throw in defaultNamespace as an alternative name. imho reasons why it's better:

  • installation feels much closer to PackageInstall but this field is also available on App
  • this namespace is used as a default namespace for resources that do not specify a namespace, but doesnt actually override it afaik

@praveenrewar praveenrewar changed the title Add installationNamespace in pkgi/app crs Add defaultNamespace in pkgi/app crs Sep 19, 2023
@praveenrewar praveenrewar marked this pull request as ready for review September 19, 2023 15:37
Copy link
Contributor

@neil-hickey neil-hickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praveenrewar praveenrewar merged commit 5aac6ae into develop Sep 21, 2023
10 checks passed
@praveenrewar praveenrewar deleted the installation-namespace branch September 21, 2023 09:09
@praveenrewar praveenrewar restored the installation-namespace branch September 26, 2023 13:35
@praveenrewar praveenrewar deleted the installation-namespace branch April 29, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ability to create app resources in a different namespace
3 participants