From f25dab149abcb6592677ba2edd5b0d8b0271c1d2 Mon Sep 17 00:00:00 2001 From: Premkumar Bhaskal Date: Wed, 22 Nov 2023 17:04:18 +0530 Subject: [PATCH] Updating default value for kube-api-qps and kube-api-burst for kapp Signed-off-by: Premkumar Bhaskal --- pkg/config/config.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkg/config/config.go b/pkg/config/config.go index 4b165a39c..efdcf96d7 100644 --- a/pkg/config/config.go +++ b/pkg/config/config.go @@ -164,11 +164,16 @@ func (gc *Config) KappDeployRawOptions() []string { gc.dataLock.RLock() defer gc.dataLock.RUnlock() + kappOptions := make([]string, 0) // Configure kapp to keep only 5 app changes as it seems that // larger number of ConfigMaps negative affects other controllers on the cluster. // Eventually kapp can be smart enough to keep minimal number of app changes. // Set default first so that it can be overridden by user provided options. - return append([]string{"--app-changes-max-to-keep=5"}, gc.data.kappDeployRawOptions...) + kappOptions = append(kappOptions, "--app-changes-max-to-keep=5") + kappOptions = append(kappOptions, "--kube-api-qps=50", "--kube-api-burst=100") + kappOptions = append(kappOptions, gc.data.kappDeployRawOptions...) + + return kappOptions } // AppDefaultSyncPeriod returns duration that is used by Apps