-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install script improvements #656
Comments
This would actually be true for all the tools so we should probably move this issue |
Thanks for bringing this up! The ask is reasonable, but I believe we should see if folks run into this often. |
Can I work on this project! |
@Kiran-pro2001 Sure! Feel free to raise a PR. |
As a matter of fact, the script is autogenerated from the template in https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt, so any change should be done there. |
Hey! Can I work on this Issue? |
The PR #785 was created against this repo and I asked @Jenil1905 to create it in the https://github.com/carvel-dev/release-scripts repository. Was not sure if the answer was "no, I will not do it" or "no, I do not mind creating the PR in that repo" 😄 |
The current install script has bogus requirements of bash and shasum. Because of the way it is written the script runs fine with sh and sha1sum.
This should be fixed because some environments, for example the Alpine Linux docker image, do not have them.
If you are checking for curl and wget, you should also check for sha1sum (or better yet use sha256sum).
The hard requirement on bash is just unneeded.
The requirements can easily be bypassed by just faking the environment, proving my point:
The text was updated successfully, but these errors were encountered: