Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install script improvements #656

Open
davidpanic opened this issue Jun 14, 2023 · 7 comments
Open

Install script improvements #656

davidpanic opened this issue Jun 14, 2023 · 7 comments
Labels
enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@davidpanic
Copy link

The current install script has bogus requirements of bash and shasum. Because of the way it is written the script runs fine with sh and sha1sum.

This should be fixed because some environments, for example the Alpine Linux docker image, do not have them.
If you are checking for curl and wget, you should also check for sha1sum (or better yet use sha256sum).

The hard requirement on bash is just unneeded.

The requirements can easily be bypassed by just faking the environment, proving my point:

cat <(echo "BASH_VERSION=fake; function shasum() { sha1sum $@; }") <(wget -O- https://carvel.dev/install.sh) | sh
@davidpanic davidpanic added the carvel triage This issue has not yet been reviewed for validity label Jun 14, 2023
@100mik
Copy link
Contributor

100mik commented Jun 19, 2023

This would actually be true for all the tools so we should probably move this issue

@100mik 100mik transferred this issue from carvel-dev/ytt Jun 19, 2023
@100mik 100mik added enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. and removed carvel triage This issue has not yet been reviewed for validity labels Jun 19, 2023
@100mik
Copy link
Contributor

100mik commented Jun 19, 2023

Thanks for bringing this up! The ask is reasonable, but I believe we should see if folks run into this often.
If this is a recurring pain point then we would be open to working towards a solution 🙏🏼

@renuy renuy moved this to Unprioritized in Carvel Jun 20, 2023
@renuy renuy moved this from Unprioritized to Prioritized Backlog in Carvel Jun 20, 2023
@renuy renuy added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Jun 20, 2023
@Kiran-pro2001
Copy link

Can I work on this project!

@praveenrewar
Copy link
Member

@Kiran-pro2001 Sure! Feel free to raise a PR.

@joaopapereira
Copy link
Member

As a matter of fact, the script is autogenerated from the template in https://github.com/carvel-dev/release-scripts/blob/main/scripts/install_sh/install.sh.txt, so any change should be done there.

@Ghanasree
Copy link

Hey! Can I work on this Issue?

@joaopapereira
Copy link
Member

The PR #785 was created against this repo and I asked @Jenil1905 to create it in the https://github.com/carvel-dev/release-scripts repository. Was not sure if the answer was "no, I will not do it" or "no, I do not mind creating the PR in that repo" 😄
Nevertheless I am open to any of you 2 to create a PR in that repository and I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue is a feature request good first issue An issue that will be a good candidate for a new contributor priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
Status: Prioritized Backlog
Development

No branches or pull requests

7 participants