Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the transaction confirmation page #1170

Open
4 tasks
Tracked by #1062
clicksave opened this issue Dec 17, 2024 · 0 comments
Open
4 tasks
Tracked by #1062

Updates to the transaction confirmation page #1170

clicksave opened this issue Dec 17, 2024 · 0 comments

Comments

@clicksave
Copy link

When transferring tokens out of your controller you see a 'confirm transaction page' this page should contain all relevant information about the transaction

At the moment theres some key information missing. at a glance you don't know the Recipient or the amount being sent

image

Should look like this

image

https://www.figma.com/design/OSbzNkyR9UYV4Erz9oF9JJ/%F0%9F%95%B9%EF%B8%8F-Controller?node-id=7523-15311&t=ZqaYZYeJ0VHSRIrA-1


There a quite a few changes here

  • Show destination address (including wallet icon/profile pfp if knowable) (including stark domain/subdomain if knowable)
  • Show transfer amount and value (denominated in USD by default)
  • Add a reject button
  • Update the page icon to the currency thats being sent

Note: this is a bit different from a manual TXN page which you'd see if a game created a txn that fell outside of the scope of a session. This is specifically for txns that are being sent via ERC 20 transfers

@clicksave clicksave mentioned this issue Dec 17, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant