Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test payable vouchers #91

Closed
ZzzzHui opened this issue Jun 29, 2023 · 0 comments · Fixed by #45
Closed

Test payable vouchers #91

ZzzzHui opened this issue Jun 29, 2023 · 0 comments · Fixed by #45
Assignees
@guidanoli
Labels
A-tests Area: tests T-feature Type: feature
Milestone
2.0.0

Comments

@ZzzzHui
Copy link
Contributor

ZzzzHui commented Jun 29, 2023 •
edited by guidanoli
Loading

📚 Context

Payable voucher PR is missing tests.

✔️ Solution

Add voucher tests controlling for each field.

Field Possible cases
Destination EOA, contract
Value Zero, Non-zero
Payload Empty, Non-empty

In total, there will be $2^3 = 8$ test cases.
@ZzzzHui ZzzzHui self-assigned this Jun 29, 2023
@ZzzzHui ZzzzHui linked a pull request Jun 29, 2023 that will close this issue
payable vouchers tests and withdrawEther function cartesi/rollups#126
Closed
@guidanoli guidanoli added this to the 2.0.0 milestone Sep 18, 2023
@guidanoli guidanoli removed a link to a pull request Sep 26, 2023
payable vouchers tests and withdrawEther function cartesi/rollups#126
Closed
@guidanoli guidanoli transferred this issue from cartesi/rollups Sep 26, 2023
@guidanoli guidanoli changed the title Payable voucher tests and deprecate CartesiDapp.withdrawEther() Test payable voucher Sep 26, 2023
@guidanoli guidanoli changed the title Test payable voucher Test payable vouchers Sep 26, 2023
@guidanoli guidanoli added T-feature Type: feature D-average A-tests Area: tests labels Sep 26, 2023
@guidanoli guidanoli moved this from 🏗 In progress to 📋 Backlog in Rollups Unit Sep 26, 2023
@guidanoli guidanoli mentioned this issue Oct 3, 2023
Merged
@guidanoli guidanoli linked a pull request Oct 3, 2023 that will close this issue
feat!: allow vouchers to transfer Ether #45
Merged
@guidanoli guidanoli self-assigned this Oct 3, 2023
@guidanoli guidanoli moved this from 📋 Backlog to 🏗 In progress in Rollups Unit Oct 3, 2023
@guidanoli guidanoli modified the milestones: 2.0.0, 3.0.0 Oct 5, 2023
@pedroargento pedroargento removed this from the 3.0.0 milestone Nov 9, 2023
@guidanoli guidanoli added this to the 2.0.0 milestone Jan 21, 2024
@guidanoli guidanoli moved this from 🚧 In progress to 👀 Under review in Rollups Unit Jan 26, 2024
@guidanoli guidanoli moved this from 👀 Under review to 🚀 Done in Rollups Unit Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guidanoli guidanoli

Labels
A-tests Area: tests T-feature Type: feature
Projects
Rollups Unit
Status: 🚀 Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

feat!: allow vouchers to transfer Ether cartesi/rollups-contracts
3 participants
@pedroargento @guidanoli @ZzzzHui