Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the sharing service from the UI #254

Open
clayne11 opened this issue Nov 20, 2015 · 1 comment
Open

Decouple the sharing service from the UI #254

clayne11 opened this issue Nov 20, 2015 · 1 comment
Labels

Comments

@clayne11
Copy link

This package would be a lot more flexible if the UI was completely decoupled from the sharing service. I would love to be able to call new ShareButton(), have the config take in a "render" function for each network, and call that function to actually render the DOM elements for the given network.

It would then return the DOM element wrapping all the buttons and allow me to insert that into the DOM myself. This would allow for a 100% flexible UI, and have nicely decoupled code.

@hhsnopek
Copy link
Contributor

Hey @clayne11 for now this is meant to be a drop-and-go library instead of full customization. This is a great idea for a future/major release of share-button!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants