Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adult same day extraneous step #78

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Fix adult same day extraneous step #78

wants to merge 23 commits into from

Conversation

delosh653
Copy link
Collaborator

Fixes #73 (Loss of good data due to excess Extraneous Same Day exclusions).

@delosh653 delosh653 marked this pull request as draft June 29, 2022 20:12
@dchud dchud mentioned this pull request Jul 27, 2022
Open
delosh653 added 17 commits July 28, 2022 14:50
@delosh653
Update sde steps to new rules
347c53b
@delosh653
Update SDE rules for EWMA comparison
18216c4
@delosh653
Fix EWMA calculations for SDEs, without SDE in weighting
a8e8eef
@delosh653
Fix bugs for next day differences
4c2791c
@delosh653
Fix tests for SDE
309be5d
@delosh653
Update remaining SDE test
ce7515c
@delosh653
Add check for any extraneous remaing with step order change
7bfd295
@delosh653
Update duplicate ratio to compare days, not observations
e31c8ef
@delosh653
Add equals to duplicate ratio cutoff
747c11b
@delosh653
Add SDE rule for trivial differences
49c5c8c
@delosh653
Update placement of new SDE rule, update codes temporarily
067fa9a
@delosh653
Update duplicate ratio to disinclude exact, add testing
6b35b9b
@delosh653
Update similar step to come before duplicate/adjacent step
99e8639
@delosh653
Fix "weight allow" to find min across both days
3b934b5
@delosh653
Add esd_strict, default false, to add looser criteria to SDE
2d4419e
@delosh653
Update adjacent rules for SDEs, both strict and loose
5f0179b
@delosh653
Fix bug related to median calculation
2213886
@dchud dchud added this to the v3.0.0 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

Loss of good data due to excess Extraneous Same Day exclusions
2 participants
@delosh653 @dchud