Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update output and description of model.summary() #534

Open
2 of 4 tasks
ashwinvis opened this issue Jan 14, 2025 · 3 comments
Open
2 of 4 tasks

Update output and description of model.summary() #534

ashwinvis opened this issue Jan 14, 2025 · 3 comments
Assignees

Comments

@ashwinvis
Copy link
Collaborator

ashwinvis commented Jan 14, 2025

  • The output shows a gridded table which is nicer to look at
  • It also contains a new information which displays the memory requirement of the model weights. See here for the implementation:

https://github.com/keras-team/keras/blob/bb340d6780fdd6e115f2f4f78d8dbe374971c930/keras/src/utils/summary_utils.py#L33-L58

Tasks

Preview Give feedback
@ashwinvis
Copy link
Collaborator Author

@svenvanderburg the model.summary() output looks fine in desktop, but garbled at least in Android's mobile browsers. I don't know if this is a deal breaker or not, but take a look here:

https://carpentries-incubator.github.io/deep-learning-intro/3-monitor-the-model.html#early-stopping-stop-when-things-are-looking-best

And it is also an issue with use of rich, as I can see the same issue over here:

https://rich.readthedocs.io/en/stable/tables.html

@carschno
Copy link
Collaborator

The table looks fine for me on my mobile in Firefox. I suppose you tested on Chrome?
Anyway, I don't think it's a dealbreaker. I would not expect wide tables to be very accessible on small screens, although that would be ideal, of course.

@ashwinvis
Copy link
Collaborator Author

It was on Firefox and Edge actually. It is still readable, just the table grid lines get offset to the right in a strange way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants