Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: improve debug local tests #30

Open
carlosrsabreu opened this issue Jan 30, 2023 · 0 comments · May be fixed by #72
Open

[FEATURE]: improve debug local tests #30

carlosrsabreu opened this issue Jan 30, 2023 · 0 comments · May be fixed by #72
Labels
🪄 enhancement New feature or enhancement ⚠️ help wanted Extra attention is needed

Comments

@carlosrsabreu
Copy link
Owner

Is your feature request related to a problem? Please describe.

A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

We need to improve our local tests, so we can have our *.py files cleaned out of debug code.

Describe the solution you'd like

A clear and concise description of what you want to happen.

As suggested by the @joaoofreitas:

  • Remove Debug info and maybe create a python test file;
  • Encapsulate debug code inside a callable function for testing and re-usability.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

N.A.

Additional context

Add any other context or screenshots about the feature request here.

# FIXME (DEBUG) Print se the filename to scrape the content
print(newest_pdf_filename)
# FIXME (DEBUG): Working link to Joram PDF
debug_pdf_joram = "https://joram.madeira.gov.pt/joram/2serie/Ano%20de%202022/IISerie-138-2022-07-22Supl.pdf"
Tip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪄 enhancement New feature or enhancement ⚠️ help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants