-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support installing extra files (man, completions, etc.) #1978
Comments
Yes, if we have a standard for distributing man pages/completion then cargo-binstall can do it It shouldn't be too difficult implementation wise. I'd imagine we will have "bash-completion" and "command.man"? And probably need to support overriding it in package.binstall I think it's a good idea and I'd welcome any PR for it, I am a bit busy recently and don't have much time to implement features unfortunately. |
So this is a little about front-running the standard, so long as you're ok with this existing as part of binstall in general terms, I'm happy to put in some work to make something that works. |
Yes I am definitely ok with that, it's just that nowadays I don't have much time myself doing new features. |
I'm also going to say that the cargo-dist people probably have an opinion and they already have some kind of manifest which may already support some of this. |
What would be the best way to check that opinion? I'm not super familiar with cargo-dist as a tool. |
Asking on their bugtracker or their discord. |
I'd like a solution for installing shell completion files during installation. Eventually this should be part of cargo install, but it's desirable to shortcut the RFC process by implementing this as a convention (to avoid letting perfect be the enemy of good).
In rust-lang/cargo#2729 (comment) (which covers man pages, but is just as relevant to completions), @matklad summarized one part of a possible solution:
(The entire comment is worth reading for more context, I've copied just the most relevant parts).
cargo-binstall seems like it might be a good place to do this experiment.
I propose that:
$CARGO_HOME/share/man
, bash completions to$CARGO_HOME/share/bash-completions/completions
(these are checked by man / bash automatically for most systems, fish and zsh completions will need some extra config)The text was updated successfully, but these errors were encountered: