Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.10.13 fails to apply permissions #1975

Open
mjpieters opened this issue Nov 19, 2024 · 1 comment
Open

Version 1.10.13 fails to apply permissions #1975

mjpieters opened this issue Nov 19, 2024 · 1 comment

Comments

@mjpieters
Copy link
Contributor

We are running cargo-binstall in a docker container to install the typos-cli command-line tool. With release 1.10.13 this no longer works, as we end up with /usr/local/cargo/bin/typos installed with incorrect permissions. If we go back to version 1.10.12 of cargo-binstall, the permissions are once again correct.

Our CI runs docker-in-docker inside a Debian Bullseye Slim container, where docker-ce-cli=5:20.10.* is installed, so Docker version 20.10.x. The exact command run is:

ARG BINSTALL_VERSION=1.10.13
ARG TYPOS_VERSION=1.27.3
RUN curl -L --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/cargo-bins/cargo-binstall/main/install-from-binstall-release.sh \
    | sed 's#${BINSTALL_VERSION}/download#download/v${BINSTALL_VERSION}#' | bash \
  && cargo binstall --no-confirm --no-track typos-cli@${TYPOS_VERSION} \
  && ls -la /usr/local/cargo/bin/typos

(Note that the above includes my work-around for #1974). The end result is a typos file with no executable permissions; the ls command outputs:

-rw-r--r--. 1 root root 14997504 Nov 19 10:14 /usr/local/cargo/bin/typos

When I use version 1.10.12, the installed file has the correct permissions. I've put the output of --log-level debug in a gist, even though it doesn't, to me, offer any clues as to what is going wrong. The 1.10.13 output looks identical to me.

@NobodyXu
Copy link
Member

I suspected this is due to #1969 which we upgrades reflink-copy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants