Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from jest to vitest #115

Open
bucko13 opened this issue Jul 25, 2024 · 12 comments
Open

Migrate from jest to vitest #115

bucko13 opened this issue Jul 25, 2024 · 12 comments
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed

Comments

@bucko13
Copy link
Contributor

bucko13 commented Jul 25, 2024

Jest as a project seems to be under-resourced. It has issues with newer technologies like ES Modules. Vitest seems to be better maintained, more modern and has a better DX/UX>

@bucko13 bucko13 added help wanted Extra attention is needed dependencies Pull requests that update a dependency file labels Jul 25, 2024
@Legend101Zz
Copy link
Contributor

Hi Buck ....
So do you want to rewrite all the tests for the packages and coordinator to vitest ?
I'll be more than happy to contribute once I am done with integrating the fees package to the main coordinator :)

@bucko13
Copy link
Contributor Author

bucko13 commented Aug 8, 2024

That’s the idea yeah! And that’d be amazing. Vitest did try and keep its API as close to the same as jest as possible so hopefully it’s an easy transition 🤞

@Legend101Zz
Copy link
Contributor

Ah Great !! So can we start with packages first ... Because I have a got a solid grasp of bitcoin , psbt and client packages so rewriting tests for them would be a great starting point for me I guess ... also learning something new is always great :)

@DhairyaMajmudar
Copy link

Hi @bucko13 @Legend101Zz this issues seems to be interesting, would love to collaborate, found a very good blog which can be helpful

https://medium.com/wiiisdom-labs/how-to-migrate-from-jest-to-vitest-without-headaches-ee200510738e

@Legend101Zz
Copy link
Contributor

Legend101Zz commented Aug 24, 2024

Hi @DhairyaMajmudar thanks for help, would you like to contribute with me to start working on this issue .... we were planning on starting with the packages first ... so maybe we can decide on how to divide them and start by creating a new branch to which we both then can contribute and create a draft PR for it then ...

@DhairyaMajmudar
Copy link

Yes definitely @Legend101Zz let's collaborate : )

@Legend101Zz
Copy link
Contributor

Great , what would be your preferred channel of communication @DhairyaMajmudar , if you prefer we can keep the conversations here itself or else anywhere that you suggest .. :)

@DhairyaMajmudar
Copy link

Great , what would be your preferred channel of communication @DhairyaMajmudar , if you prefer we can keep the conversations here itself or else anywhere that you suggest .. :)

Is there a Slack/Discord of caravan where we can connect ?

@Legend101Zz
Copy link
Contributor

Great , what would be your preferred channel of communication @DhairyaMajmudar , if you prefer we can keep the conversations here itself or else anywhere that you suggest .. :)

Is there a Slack/Discord of caravan where we can connect ?

I don't know of any such existing channels .... there is a discord subchannel of caravan in SOB's discord but I think that might not be the right place , @DhairyaMajmudar can we just connect on discord then ... and have things started ?

@DhairyaMajmudar
Copy link

Sure @Legend101Zz let's connect on discord dhairya7 here's my username : )

@DhairyaMajmudar
Copy link

Hi, @bucko13 upon discussion with @Legend101Zz in discord chat we have come to an approach to create a separate migration branch in the main repo. where we both can collaborate by opening small-medium sized pull requests. Separating the migration will help maintainers review the PRs in a more effective way.

Needed your help in making a separate branch since we don't have write access to repo.

@bucko13
Copy link
Contributor Author

bucko13 commented Aug 27, 2024

Thanks guys! I've started a feature branch y'all can target vite-migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants