Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Technical Debt) Dependencies on references to internal column/list item names #1

Open
robne1982 opened this issue Jun 1, 2017 · 1 comment

Comments

@robne1982
Copy link
Collaborator

robne1982 commented Jun 1, 2017

(Ported from another server)

This is mostly just a small technical debt issue.

To give an example of the dependencies I mean, the createColMatching function has hardcoded references to the names of the columns in the matchColumns output that have the name of the columns and the flag for whether it's in A or B. This means we'd have to change it in multiple places if we changed it in the actual matchColumns location, and this is not ideal, nor obvious. It would be better if we could find a way to reduce those kinds of dependencies somehow (passing references or keeping that info in some type of central location, etc.)

@robne1982
Copy link
Collaborator Author

This cropped up as a warning on the R CMD checks. Worked around with zzz.R setting global variables as recommended by Hadley at http://stackoverflow.com/questions/9439256/how-can-i-handle-r-cmd-check-no-visible-binding-for-global-variable-notes-when

This approach doesn't fill me with joy, but I'm marking this as wontfix because I think passing R CMD checks is sufficient for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant