-
Notifications
You must be signed in to change notification settings - Fork 48
Respose headers not saved when using Mocktail format #4
Comments
We do not want to save every response header to reduce the size. Do you have a need to save a particular header for your app? Do you have any thoughts over how to do it, maybe a pull request once figured it out? |
For debug and test purpose, does size matter? and absence of headers make the record useless. I think it's easy to add headers, like in SWHTTPTrafficRecordingFormatHTTPMessage format. |
You convinced me:-] If you have a ready to check in code (and make sure that it can be consumed by Mocktail lib or OHHTTPStatus), feel free to submit a pull request. Otherwise I will dig the code to record header and put it in. |
I just found this issue so I haven't any code for this, but I will fork and try to add header info, If I can make it work with OHHTTPStubs, I will make a PR. |
@JustinMollenauer This is the issue we talked about. If you can pull in your code here, that would be really great help. Thanks! |
@JinlianWang I submitted PR #9 with the code for adding headers. |
@wangyun The headers are recorded now. If you have a chance to verify and close the issue, that would be great. |
@JustinMollenauer Can you please confirm that PR #9 solves the issue, so that we can close this issue? |
@jaredsmith Can confirm, PR #9 fixed this issue. |
Respose headers not saved when using Mocktail format
The text was updated successfully, but these errors were encountered: