Skip to content
This repository has been archived by the owner on Jul 27, 2019. It is now read-only.

Respose headers not saved when using Mocktail format #4

Open
wangyun opened this issue Mar 28, 2016 · 9 comments
Open

Respose headers not saved when using Mocktail format #4

wangyun opened this issue Mar 28, 2016 · 9 comments

Comments

@wangyun
Copy link

wangyun commented Mar 28, 2016

Respose headers not saved when using Mocktail format

@JinlianWang
Copy link
Contributor

We do not want to save every response header to reduce the size. Do you have a need to save a particular header for your app? Do you have any thoughts over how to do it, maybe a pull request once figured it out?

@wangyun
Copy link
Author

wangyun commented Mar 29, 2016

For debug and test purpose, does size matter? and absence of headers make the record useless. I think it's easy to add headers, like in SWHTTPTrafficRecordingFormatHTTPMessage format.

@JinlianWang
Copy link
Contributor

You convinced me:-] If you have a ready to check in code (and make sure that it can be consumed by Mocktail lib or OHHTTPStatus), feel free to submit a pull request. Otherwise I will dig the code to record header and put it in.

@wangyun
Copy link
Author

wangyun commented Mar 30, 2016

I just found this issue so I haven't any code for this, but I will fork and try to add header info, If I can make it work with OHHTTPStubs, I will make a PR.

@JinlianWang
Copy link
Contributor

@JustinMollenauer This is the issue we talked about. If you can pull in your code here, that would be really great help. Thanks!

@JustinMollenauer
Copy link

@JinlianWang I submitted PR #9 with the code for adding headers.

@JinlianWang
Copy link
Contributor

@wangyun The headers are recorded now. If you have a chance to verify and close the issue, that would be great.

@jaredsmith
Copy link

@JustinMollenauer Can you please confirm that PR #9 solves the issue, so that we can close this issue?

@JustinMollenauer
Copy link

@jaredsmith Can confirm, PR #9 fixed this issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants