Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Maps #20

Closed
Ionitron opened this issue Jun 17, 2020 · 27 comments
Closed

Google Maps #20

Ionitron opened this issue Jun 17, 2020 · 27 comments
Labels
incompatible cordova plugin exists An incompatible Cordova plugin exists already plugin proposal

Comments

@Ionitron
Copy link
Member

Ionitron commented Jun 17, 2020

Plugin Request

Name: Google Maps
Package: @capacitor-community/google-maps

Platform(s)

Android, iOS

Existing Solutions

https://github.com/mapsplugin/cordova-plugin-googlemaps, but doesn't work in Capacitor iOS yet (see mapsplugin/cordova-plugin-googlemaps#2781)

An alternative would be using the web SDK as shown in this blog by Josh Morony. Using the native SDK has several benefits, however: fewer requests, offline map caching, ability to work offline, etc.

Description

A plugin for using the native Google Maps SDK.

@Ionitron
Copy link
Member Author

Original request: ionic-team/capacitor#629

@hemangsk
Copy link

hemangsk commented Jul 1, 2020

https://github.com/hemangsk/capacitor-googlemaps-native has some basic google maps working for android and ios (using native SDK) and can be used in Capacitor apps. Some features like street view, drawings are not there yet and its currently under development for this reason, please feel free to join forces & collaborate! :)

@wf9a5m75
Copy link

wf9a5m75 commented Jul 4, 2020

@hemangsk Thank you for the information. This is just my curiosity. Is the capacitor-googlemaps-native able to display a side bar over the map (like this image)?

As you can see, I expect touch the menu items over the map.

capture (1)

By the way, I have been working on this project recently.
It means cordova-plugin-googlemaps will support Capacitor iOS officially.

@imhoffd
Copy link
Contributor

imhoffd commented Jul 6, 2020

Thanks @wf9a5m75, I've updated the proposal with the current status of your plugin.

@tototares
Copy link

@wf9a5m75 Will support your plugin only IOS? What's about Android?

@wf9a5m75
Copy link

wf9a5m75 commented Jul 6, 2020

Cordova-plugin-googlemaps with @ionic-native/google-maps works on Capacitor Android currently

@tototares
Copy link

@wf9a5m75 that's true but for that you need ionic-native. Would be great to have a plugin for iOS and Android where you doesn't need something else but capacitor.

@wf9a5m75
Copy link

wf9a5m75 commented Jul 6, 2020

In the future, probably yes, but step by step

@imhoffd imhoffd added the incompatible cordova plugin exists An incompatible Cordova plugin exists already label Jul 13, 2020
@hemangsk
Copy link

hemangsk commented Jul 16, 2020

@wf9a5m75 I'm quite certain https://github.com/hemangsk/capacitor-googlemaps-native could do that,

This is just my curiosity. Is the capacitor-googlemaps-native able to display a side bar over the map (like this image)?

but if you're not being able to get that look which you are going for, let me know in the issues here and I'll try to help you with a workaround :)

@wf9a5m75
Copy link

Thanks, but so far so good. Capacitor iOS supporting project is on the way. I will ask your help when I need.

@THEDOWNCOUNTRY
Copy link

@wf9a5m75 when will the plugin be available for iOS?

@DwieDima
Copy link

@THEDOWNCOUNTRY project started on 24. june and estimated time was 3 months. It got extended for another month, so release should hopefully be on 24. october.

@THEDOWNCOUNTRY
Copy link

@DwieDima hopefully because this plugin is awesome. At the moment, to use it for iOS, I only have CORDOVA plugins on my project, so I don't have to rewrite code for android, and that's frustrating when some plugins like firebase analytics don't work for android.

@SalahAdDin
Copy link

@DwieDima how was it?

@DwieDima
Copy link

@DwieDima how was it?

@SalahAdDin no ETA
you can track current state of development here:
mapsplugin/cordova-plugin-googlemaps#2781

@SalahAdDin
Copy link

@hemangsk is it still active?

@selected-pixel-jameson
Copy link

Where is the Ionic / Capacitor team in all of this? It seems like core functionality to have the maps SDK in any kind of mobile framework. Its pretty much non-existent for iOS. The Cordova plugin doesn’t work for iOS and the development progress is at a standstill. Let’s get this moving forward. @capacitor-community-bot @Ionitron

@wf9a5m75
Copy link

@selected-pixel-jameson Why don't you try to create a new plugin by yourself?

@selected-pixel-jameson
Copy link

@wf9a5m75 I'm at this point. However, it would make a lot more sense to have three people working on the development of one capacitor native maps plugin vs three separate ones that are partially done. I'll probably just reach out to @hemangsk to see if they are open to pull requests.

@tototares
Copy link

@wf9a5m75 I'm at this point. However, it would make a lot more sense to have three people working on the development of one capacitor native maps plugin vs three separate ones that are partially done. I'll probably just reach out to @hemangsk to see if they are open to pull requests.

yeah I agree! He is answering to pull requests very fast and there is no other capacitor project for native maps support for ios and android.

@wf9a5m75
Copy link

Ok, no problem. Existing choice is a good option. I'm developing a new version, but a lots of task. But certainly I'm not "standstill"

@AE1NS
Copy link

AE1NS commented Feb 24, 2021

@wf9a5m75 will it be open source later? Maybe you could set your repository to public with the current state to let other skilled developers contribute and support you with completing it, like @selected-pixel-jameson mentioned. We appreciate all your work @wf9a5m75 and @hemangsk!

@wf9a5m75
Copy link

will be open source?

Tentatively, yes. But many people did only request instead of contribution. I'm considering.

@selected-pixel-jameson
Copy link

Just an updated to the @capacitor-community-bot on where Capacitor is on the progress of having native maps implementation.

@hemangsk and @wf9a5m75 are both working away to try and get releases out, but obviously this is quite an undertaking.

@wf9a5m75 has a private repo he has shared with individuals who have donated to the project. Progress is being made and updates are sent out every few weeks or so.

@hemangsk has a public version that receives updates pretty often. They seem to respond quickly to issues posted as well. There are two items with this repo that I would consider preventing it from a fully usable solution.

  1. The map cannot be used inline. Right now they are working through figuring this out.
  2. Info boxes are not yet implemented.

With all this said I want to thank @hemangsk and @wf9a5m75 for their work. Hopefully we will have two viable production options within the next month or so.

@wf9a5m75
Copy link

@selected-pixel-jameson I understand your frustration. I apologize my work progress is super slow. I'm very hard to find the working time of the maps plugin at this moment.

@riderx
Copy link

riderx commented Nov 18, 2021

@hemangsk add your plugin to awesome-capacitor if that is useful please take time to star the repo as well :)

@jcesarmobile
Copy link

there is @capacitor-community/google-maps and @capacitor/google-maps plugins available, closing the proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible cordova plugin exists An incompatible Cordova plugin exists already plugin proposal
Projects
None yet
Development

No branches or pull requests