From c027f8cc314ec7531f28ed4fd59bfb513712c092 Mon Sep 17 00:00:00 2001 From: D070615 Date: Thu, 7 Mar 2024 17:24:22 +0100 Subject: [PATCH 1/5] added limitations for compositions of one --- cds/cdl.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cds/cdl.md b/cds/cdl.md index 591918d89..8410ec25a 100644 --- a/cds/cdl.md +++ b/cds/cdl.md @@ -690,6 +690,12 @@ entity Orders.Items { Essentially, Compositions are the same as _[associations](#associations)_, just with the additional information that this association represents a _contained-in_ relationship so the same syntax and rules apply in their base form. ::: +::: warning Limitations of Compositions of one +Don't overuse Compositions of one. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: +- Very limited Draft support. Fiori UIs almost never send Draft requests with Compositions of one. In rare cases when it happens, you need to take case of them in a custom handler. +- No support for POST requests over navigation with Compositions of one. If you can't avoid this scenario, please fill foreign keys manually in a custom handler. +::: + ### Managed Compositions of Aspects {#managed-compositions} Use managed compositions variant to nicely reflect document structures in your domain models, without the need for separate entities, reverse associations, and unmanaged `on` conditions. From c23d6f9ac7446b7a4e4314a6552d87abc591448a Mon Sep 17 00:00:00 2001 From: Nick Josipovic Date: Fri, 8 Mar 2024 09:03:45 +0100 Subject: [PATCH 2/5] add David's comments Update cds/cdl.md Co-authored-by: Dr. David A. Kunz --- cds/cdl.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cds/cdl.md b/cds/cdl.md index 8410ec25a..5ab0a2db0 100644 --- a/cds/cdl.md +++ b/cds/cdl.md @@ -692,7 +692,7 @@ Essentially, Compositions are the same as _[associations](#associations)_, just ::: warning Limitations of Compositions of one Don't overuse Compositions of one. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: -- Very limited Draft support. Fiori UIs almost never send Draft requests with Compositions of one. In rare cases when it happens, you need to take case of them in a custom handler. +- Very limited Draft support. Fiori elements does not support Compositions of one unless you take case of their creation in a custom handler. - No support for POST requests over navigation with Compositions of one. If you can't avoid this scenario, please fill foreign keys manually in a custom handler. ::: From 7505db48c849bd6937a4e4ae8a4e697ab721818e Mon Sep 17 00:00:00 2001 From: D070615 Date: Fri, 8 Mar 2024 11:05:06 +0100 Subject: [PATCH 3/5] review fix --- cds/cdl.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cds/cdl.md b/cds/cdl.md index 5ab0a2db0..d81f8029a 100644 --- a/cds/cdl.md +++ b/cds/cdl.md @@ -691,9 +691,9 @@ Essentially, Compositions are the same as _[associations](#associations)_, just ::: ::: warning Limitations of Compositions of one -Don't overuse Compositions of one. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: -- Very limited Draft support. Fiori elements does not support Compositions of one unless you take case of their creation in a custom handler. -- No support for POST requests over navigation with Compositions of one. If you can't avoid this scenario, please fill foreign keys manually in a custom handler. +Don't overuse compositions of one. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: +- Very limited Draft support. Fiori elements does not support compositions of one unless you take care of their creation in a custom handler. +- No support for POST requests over navigation with compositions of one. You must fill in foreign keys manually in a custom handler. ::: ### Managed Compositions of Aspects {#managed-compositions} From e969b5d3e8c4e6f9467788b097b703d533c0f52c Mon Sep 17 00:00:00 2001 From: D070615 Date: Fri, 8 Mar 2024 16:25:10 +0100 Subject: [PATCH 4/5] review fix --- cds/cdl.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cds/cdl.md b/cds/cdl.md index d81f8029a..f15f5a16c 100644 --- a/cds/cdl.md +++ b/cds/cdl.md @@ -691,9 +691,9 @@ Essentially, Compositions are the same as _[associations](#associations)_, just ::: ::: warning Limitations of Compositions of one -Don't overuse compositions of one. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: +Using of compositions of one is discouraged. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: - Very limited Draft support. Fiori elements does not support compositions of one unless you take care of their creation in a custom handler. -- No support for POST requests over navigation with compositions of one. You must fill in foreign keys manually in a custom handler. +- No extensive support for modifications over paths if compostions of one are involved. You must fill in foreign keys manually in a custom handler. ::: ### Managed Compositions of Aspects {#managed-compositions} From 0435d9157ee758f0216f95dd159098b56e873145 Mon Sep 17 00:00:00 2001 From: D070615 Date: Tue, 12 Mar 2024 10:15:24 +0100 Subject: [PATCH 5/5] added entity --- cds/cdl.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cds/cdl.md b/cds/cdl.md index 4bc1cbbc4..a88207358 100644 --- a/cds/cdl.md +++ b/cds/cdl.md @@ -691,7 +691,7 @@ Essentially, Compositions are the same as _[associations](#associations)_, just ::: ::: warning Limitations of Compositions of one -Using of compositions of one is discouraged. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: +Using of compositions of one for entities is discouraged. There is often no added value of using them as the information can be placed in the root entity. Compositions of one have limitations as follow: - Very limited Draft support. Fiori elements does not support compositions of one unless you take care of their creation in a custom handler. - No extensive support for modifications over paths if compostions of one are involved. You must fill in foreign keys manually in a custom handler. :::