Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript: run with watch, SFlight sample #1515

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Typescript: run with watch, SFlight sample #1515

wants to merge 2 commits into from
+47 −21

Conversation

chgeo
Copy link
Member

@chgeo chgeo commented Dec 12, 2024 •
edited
Loading

Overhaul of the ways one can run TS projects, with cds watch now being the recommended way.

Also mention SFlight as sample code for TS instead of former hello-world of cloud-cap-samples.

@chgeo chgeo requested a review from smahati as a code owner December 12, 2024 13:31
@chgeo chgeo requested a review from daogrady December 12, 2024 13:31
daogrady
daogrady reviewed Dec 12, 2024
View reviewed changes
node.js/typescript.md Outdated Show resolved Hide resolved
daogrady
daogrady reviewed Dec 12, 2024
View reviewed changes
node.js/typescript.md Outdated Show resolved Hide resolved
daogrady
daogrady reviewed Dec 12, 2024
View reviewed changes
node.js/typescript.md Outdated Show resolved Hide resolved
daogrady
daogrady approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@daogrady daogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess we should remove the logger output in cds-dk too, where we automatically detect ts projects and ask the user to use cds-ts instead?

@chgeo
Copy link
Member Author

chgeo commented Dec 12, 2024

Thanks! I guess we should remove the logger output in cds-dk too, where we automatically detect ts projects and ask the user to use cds-ts instead?

Yes. See cap/cds-dk#3188

@chgeo chgeo enabled auto-merge December 13, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daogrady daogrady daogrady approved these changes

@smahati smahati Awaiting requested review from smahati smahati is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chgeo @daogrady