helpers: avoid triggering a kernel warning #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In kernels ≥ 6.3 there's a warning generated when you create a memfd without setting one of `MFD_NOEXEC_SEAL` or `MFD_EXEC`. Since we don't need to be able to execute our shm buffers, set `MFD_NOEXEC_SEAL` when: * We're built against sufficiently new kernel headers, and * The kernel we're running on is sufficiently new. `memfd_create` will return `EINVAL` if it doesn't understand `MFD_NOEXEC_SEAL` (ie: if it's too old), so it's easy to fallback.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kernels ≥ 6.3 there's a warning generated when you create a memfd without setting one of
MFD_NOEXEC_SEALorMFD_EXEC. Since we don't need to be able to execute our shm buffers, setMFD_NOEXEC_SEALwhen:memfd_createwill returnEINVALif it doesn't understandMFD_NOEXEC_SEAL(ie: if it's too old), so it's easy to fallback.