Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to ensure xdg_surface is not assigned non extending role #244

Open
i509VCB opened this issue Sep 19, 2022 · 2 comments
Open

Test to ensure xdg_surface is not assigned non extending role #244

i509VCB opened this issue Sep 19, 2022 · 2 comments

Comments

@i509VCB
Copy link

i509VCB commented Sep 19, 2022

Per the documentation in xdg_wm_base.get_xdg_surface:

While xdg_surface itself is not a role, the corresponding surface may only be assigned a role extending xdg_surface, such as xdg_toplevel or xdg_popup

Talked with Simon about this on #wayland and he agrees that should exhibit a protocol error.

@RAOF
Copy link
Contributor

RAOF commented Sep 19, 2022

I do want to extend the set of "this should raise a protocol error" tests we have. Do you know offhand what error should be raised in this case?

@i509VCB
Copy link
Author

i509VCB commented Sep 22, 2022

This might actually depend on what role object is being created.

If you create an xdg_surface and then a layer shell, probably an error on the layer shell.

But vice versa, with a layer shell, creating an xdg_surface would probably raise an error on the xdg_surface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants