Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTA Block: Excessive bottom padding #5397

Open
jmuzina opened this issue Oct 23, 2024 · 1 comment · May be fixed by #5398
Open

CTA Block: Excessive bottom padding #5397

jmuzina opened this issue Oct 23, 2024 · 1 comment · May be fixed by #5398
Labels

Comments

@jmuzina
Copy link
Member

jmuzina commented Oct 23, 2024

While building canonical/canonical.com#1406, I noticed a visual quirk with the CTA block: we have given it padding-bottom: $spv--x-large here:

padding-bottom: $spv--x-large;

This causes some extra spacing beneath the CTA block that is not present in CTA blocks that don't use our .p-cta-block.

Default:
Screenshot 2024-10-23 at 3 19 22 PM

Expected (no bottom padding):
Screenshot 2024-10-23 at 3 19 37 PM

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-16100.

This message was autogenerated

@mcslayer mcslayer linked a pull request Oct 23, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant