Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul print CSS styles and better integrate with Vanilla core #5350

Open
pastelcyborg opened this issue Sep 13, 2024 · 3 comments
Open

Overhaul print CSS styles and better integrate with Vanilla core #5350

pastelcyborg opened this issue Sep 13, 2024 · 3 comments
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system WG: Proposal Working group proposals

Comments

@pastelcyborg
Copy link
Contributor

Component/pattern to amend

Presently, the print CSS styles for various sites tend to live in their own file:

https://github.com/canonical/ubuntu.com/blob/main/static/sass/print.scss

These print.css files also often live separately from core site styles, resulting in an extra network request to retrieve them.

There's probably an opportunity here to create some print styles as part of Vanilla core, so these don't need to be created uniquely for each site. We'll need to do some analysis to determine what various sites are doing with their print styles and which parts of these print styles could be upstreamed into new Vanilla core print styles.

@pastelcyborg pastelcyborg added the WG: Proposal Working group proposals label Sep 13, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14926.

This message was autogenerated

@danielmutis
Copy link

WG: how relevant is this today? How often do people print from websites?
This could be considered as part of the new architecture work. This part of Vanilla is very old and hasn't been touched in a long time.
Lyubo: should this be taken into consideration for each component?
@pastelcyborg @bartaz and the tribe to discuss what to do about this inside the tribe.

@bartaz
Copy link
Member

bartaz commented Sep 25, 2024

I was pretty sure we have some basic print styles, but I can't find any (apart from utility allowing you to hide things from print (https://vanillaframework.io/docs/utilities/no-print).

I guess there is not much value in addressing it in current codebase as we are moving towards new architecture. Print styles (from web) could be considered as part of new design system specs and architecture.

@bartaz bartaz added P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Triaged Issue has been reviewed as part of legacy backlog grooming (project P3). Triaged: new architecture Triaged, to be addressed in new architecture of the design system WG: Proposal Working group proposals
Projects
None yet
Development

No branches or pull requests

3 participants