Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on proxied_endpoints in the separate ingress providers #369

Open
PietroPasotti opened this issue Jun 5, 2024 · 0 comments
Open

warn on proxied_endpoints in the separate ingress providers #369

PietroPasotti opened this issue Jun 5, 2024 · 0 comments

Comments

@PietroPasotti
Copy link
Contributor

Right now traefik try/excepts on (for example IngressPerAppProvider.) .proxied_endpoints and logs to the action result that fetching the endpoints from that whole provider has failed.

We should be more lenient and, even if some relations aren't ready, still return the proxied endpoints for all the healthy ones.

That'll mean updating each of the ingress libs that have:

    @property
    def proxied_endpoints(self) -> dict:
        results = {}
        for ingress_relation in self.relations:
            provider_app_data = self._provider_app_data(ingress_relation)
            results.update(provider_app_data)
        return results

to try/except each _provider_app_data call and log a warning on failure, letting the other results be added to the results and returned.

Originally posted by @PietroPasotti in #368 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants