Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[traefik-route] There's no "route departed/broken" for TraefikRouteRequirer #345

Open
mmkay opened this issue May 1, 2024 · 1 comment

Comments

@mmkay
Copy link
Contributor

mmkay commented May 1, 2024

Bug Description

Although TraefikRouteProvider has a data_removed event: https://github.com/canonical/traefik-k8s-operator/blob/main/lib/charms/traefik_route_k8s/v0/traefik_route.py#L126

TraefikRouteRequirer only declares a ready event: https://github.com/canonical/traefik-k8s-operator/blob/main/lib/charms/traefik_route_k8s/v0/traefik_route.py#L119

That causes charms that use traefik_route not to handle ingress removed/broken/lost events (example)

To Reproduce

.

Environment

Should be the same for all environments.

Relevant log output

.

Additional context

No response

@mmkay
Copy link
Contributor Author

mmkay commented Jun 27, 2024

We could have a broken event that could make the API consistent.

@dstathis dstathis added Checked and removed Checked labels Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants