Octavia deployment fails

[nicolasbock]

When creating a simple Octavia deployment with

./generate-bundle.sh --series focal --release yoga --ovn --octavia --octavia-ovn-provider --name fy-ovn2

I get

$ ./tools/vault-unseal-and-authorise.sh
$ ./configure
$ ./tools/sec_groups.sh
$ ./tools/instance_launch.sh 1 focal

The focal instance wasn't uploaded, so I invoked

$ ./tools/upload_image.sh cloudimages focal focal-server-cloudimg-amd64.img qcow2
$ ./tools/instance_launch.sh 1 focal
$ ./tools/float_all.sh 

Then I ssh to the instance and installed apache. The command to ssh to the
instance was wrong in the description

./tools/create_octavia_lb.sh --member-vm <uuid from prev step>

here ^ the loadbalancer creation failed with error:

octavia.common.exceptions.ComputeBuildException: Failed to build compute instance due to: Failed to retrieve image with octavia-amphora tag

So I ran:

openstack image set --tag octavia-amphora focal

then I retried to create the LB again and got:

octavia.common.exceptions.ComputeBuildException: Failed to build compute
instance due to: Invalid key_name provided

I checked /etc/octavia/octavia.conf and found:

amp_ssh_key_name = amphora-backdoor

but I checked the key_pair table in nova database and this key does not
exist there. Shouldn't the charm create it?

[nicolasbock]

Addressed in #152