tests: added nightly run from spread-cron #14729
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14729 +/- ##
==========================================
+ Coverage 78.95% 79.03% +0.08%
==========================================
Files 1084 1087 +3
Lines 146638 147906 +1268
==========================================
+ Hits 115773 116898 +1125
- Misses 23667 23769 +102
- Partials 7198 7239 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sergiocazzolato
requested changes
Nov 15, 2024
maykathm
force-pushed
the
SNAPDENG-34131-migrate-nightly-tests-from-cron-to-snapd
branch
8 times, most recently
from
795d9a0
to
def93ae
Compare
…ms; If ALL, then don't list out systems for spread
…rams to pass entire prefix
maykathm
force-pushed
the
SNAPDENG-34131-migrate-nightly-tests-from-cron-to-snapd
branch
from
0d40ace
to
b0a65c3
Compare
zyga
reviewed
Nov 27, 2024
…ap usage and check for empty rules when running spread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all cron jobs from spread-cron to snapd that run spread tests on snapd. It makes a minor change in the spread-test.yaml to allow for use of the master snap along with two required environment variables.
It also adds the possibility of executing with (in addition to manually specifying the systems) "ALL" systems or "NONE." To help not create confusion, it will no longer be possible to leave the systems input blank.
To ensure the commands will run correctly, I ran a job in snapd-ci with cron disabled to check the executed spread commands. To ensure the scheduling mechanism works correctly, I pushed the changes to the master branch of snapd-ci and saw the three triggers 2 am UTC for nested and nightly, 3 am UTC for experimental and openstack, and 6 am UTC for build from current.
Cron jobs
spread-cron - snapd-nightly-suite
Command in spread-cron
Command in new nightly tests
spread-cron - snapd-test-build-from-current
Command in spread-cron
Command in new nightly tests
and
spread-cron - snapd-test-experimental
Command in spread-cron
Command in new nightly tests
spread-cron - snapd-test-openstack
Command in spread-cron
Command in new nightly tests
Currently not available because the testing environment doesn't have spread-plus. The output will be:
spread -no-debug-output -logs spread-logs openstack:tests/main/...