Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install git inside core24 build environments #4944

Closed
mr-cal opened this issue Jul 29, 2024 · 2 comments
Closed

Install git inside core24 build environments #4944

mr-cal opened this issue Jul 29, 2024 · 2 comments
Labels

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Jul 29, 2024

What needs to get done

  1. Update snapcraft.services.provider.setup() to install git:
diff --git a/snapcraft/services/provider.py b/snapcraft/services/provider.py
index 2ed2b590..e28b730c 100644
@@ -26,6 +26,12 @@ class Provider(ProviderService):
 
     @overrides
     def setup(self) -> None:
+        """Snapcraft-specific setup."""
+        # required for apt gpg and `version: git`
+        self.packages.extend(["gpg", "dirmngr", "git"])
+
         if build_info := os.getenv("SNAPCRAFT_BUILD_INFO"):
             self.environment["SNAPCRAFT_BUILD_INFO"] = build_info
         if image_info := os.getenv("SNAPCRAFT_IMAGE_INFO"):
  1. Update the compatibility tag in snapcraft (blocked by Custom compatibility tags in the provider service craft-application#105)

Why it needs to get done

  • To allow version: git and other git calls to work inside the build environment
  • Parity with core22
@mr-cal mr-cal added the triaged label Jul 29, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3171.

This message was autogenerated

@mr-cal
Copy link
Collaborator Author

mr-cal commented Nov 21, 2024

This should be fixed because we bundle git in #5149

@mr-cal mr-cal closed this as completed Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant