Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charm behaviour differs from grafana-agent for log_level config option #662

Open
MichaelThamm opened this issue Dec 20, 2024 · 0 comments
Open

Comments

@MichaelThamm
Copy link

Enhancement Proposal

The log_level config option was introduced into grafana agent machine charm inspired by the functionality from the Prometheus charm.

However, the above PR was implemented in a way that if an incorrect log level config was passed then the charm enters Blocked status rather than just silenty accepting the config and only creating a warning log message. The user may not realize their log level was not accepted.

Make this behaviour consistent here like in Grafana Agent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant