Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support charm_revision and charm_channel labels #637

Open
amandahla opened this issue Aug 16, 2024 · 3 comments
Open

Support charm_revision and charm_channel labels #637

amandahla opened this issue Aug 16, 2024 · 3 comments

Comments

@amandahla
Copy link

Enhancement Proposal

Request

Visualize each published charm revision/channel.

Screenshot from 2024-08-08 14-13-37

What we have today from Juju Topology labels

  • model name, model uuid, Application name and unit identifier.

What we want

  • charm revision and charm channel.

It could be new labels or a static metric similar to pg_static from PostgreSQL exporter. Example here.

Requires

  • information available via charm/ops.

Requested:

@amandahla amandahla changed the title Support charm_revision and charm_channel metrics Support charm_revision and charm_channel labels Oct 10, 2024
@simskij
Copy link
Member

simskij commented Nov 11, 2024

I'm not entirely convinced, as this would introduce unbound index keys (high cardinality labels), which could impact performance negatively. @sed-i, @lucabello, @MichaelThamm, @Abuelodelanada, wdyt?

@Abuelodelanada
Copy link
Contributor

I'm not entirely convinced, as this would introduce unbound index keys (high cardinality labels), which could impact performance negatively. @sed-i, @lucabello, @MichaelThamm, @Abuelodelanada, wdyt?

From my point of view introducing channel as a new label is not that bad since it is a fixed set of values (edge, beta, candidate and stable)

On the other hand introducing revision which is an auto-increment value may lead to a cardinality bomb. As fas as I understand, every new revision will create a new time series.

@amandahla
Copy link
Author

Creating a metric (charm_revision/charm_channel something) would work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants