You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If we're going to have constant [log/status message] strings this way, they could be class-level rather than instance level, or just plain ALL-CAPS constants the way the old status was (just to make it clear what they are).
Alternatively, this seems like a great place for a tiny meta-config class/method, where:
ifsome_bad_thing:
self.set_unit_status("push_fail") # or even an Enum at the top to make it self.set_unit_status(PUSH_FAIL)
Would be a nice abstraction which keeps the list of conditions->statuses in a single place, almost like a excepthook
If we're going to have constant [log/status message] strings this way, they could be class-level rather than instance level, or just plain ALL-CAPS constants the way the old status was (just to make it clear what they are).
Alternatively, this seems like a great place for a tiny meta-config class/method, where:
Would be a nice abstraction which keeps the list of conditions->statuses in a single place, almost like a
excepthook
Originally posted by @rbarry82 in #352 (comment)
The text was updated successfully, but these errors were encountered: