Run integration tests on arm64 #464
Conversation
This reverts commit 38166ed.
carlcsaposs-canonical
requested review from
taurus-forever,
dragomirp and
marceloneppel
| architecture = subprocess.run( | ||
| ["dpkg", "--print-architecture"], capture_output=True, check=True, encoding="utf-8" | ||
| ).stdout.strip() |
There was a problem hiding this comment.
I think we should rather use platform.machine() and a mapping to the correct architecture. Otherwise the tests will only run on Debian derivatives without tweaking.
There was a problem hiding this comment.
is the mapping always 1:1?
There was a problem hiding this comment.
Yes and it is what we use for installing the correct snap revision.
There was a problem hiding this comment.
are you sure mapping is always 1:1 for every architecture?
I'm wondering if there are multiple platform.machine()s that would both be amd64, for example
There was a problem hiding this comment.
Shouldn't be the case unless we start supporting *bsd, but then we also wouldn't have dpkg on the host either way. platform.machine() should respond with the same value as uname -m
There was a problem hiding this comment.
@dragomirp is there documentation somewhere about the possible values of uname -m/platform.machine()?
|
@dragomirp @marceloneppel should I merge with some integration tests failing? if not, could one of you pick up this PR? I believe the remaining test failures are postgresql-specific/require knowledge of postgres and are not related to the reusable workflows |
|
merging since test failures are identical on amd64 and arm64 |
No description provided.