Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade visualisation server ROCK to 2.3.0 #141

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

misohu
Copy link
Member

@misohu misohu commented Nov 13, 2024

Closes: #140

No changes in code the Docker image did not change
https://github.com/kubeflow/pipelines/blob/2.2.0/backend/Dockerfile.visualization
https://github.com/kubeflow/pipelines/blob/2.3.0/backend/Dockerfile.visualization

I have bumped the tags.

Steps for local comparison test

# build the ROCK
rockcraft clean && rockcraft pack --verbosity=trace
sudo rockcraft.skopeo --insecure-policy copy oci-archive:visualization-server_2.3.0_amd64.rock docker-daemon:visualization-server:2.3.0

# Upstream image 
docker run gcr.io/ml-pipeline/visualization-server:2.3.0

########################################################

# Rock 
docker run visualization-server:2.3.0

# Output
2024-11-14T09:50:45.048Z [pebble] Started daemon.
2024-11-14T09:50:45.082Z [pebble] POST /v1/services 16.662624ms 202
2024-11-14T09:50:45.100Z [pebble] Service "controller" starting: bash -c '/bin/controller --logtostderr=true --max_num_viewers=${MAX_NUM_VIEWERS} --namespace=${NAMESPACE}'
2024-11-14T09:50:45.159Z [pebble] Change 1 task (Start service "controller") failed: cannot start service: exited quickly with code 1
2024-11-14T09:50:45.175Z [pebble] GET /v1/changes/1/wait 91.71935ms 200
2024-11-14T09:50:45.175Z [pebble] Started default services with change 1.

# Output for service is hidden you need to get the id of running docker container 
docker ps
# bash into the container 
docker exec -ti <your_id> bash
# execute the service command manually
$ /bin/controller

@misohu misohu requested a review from a team as a code owner November 13, 2024 11:18
@misohu misohu merged commit a2f7f9e into main Nov 15, 2024
7 checks passed
@misohu misohu deleted the KF-6548-upgrade-visualisationserver-to-230 branch November 15, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kfp 2.3.0 upgrade visualization-server rock
2 participants